new module TroykaMeteoSensor #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrztv
suggested changes
Aug 27, 2018
| @@ -0,0 +1,113 @@ | |||
| function TroykaMeteoSensor(opts) { | |||
| opts = opts || {}; | |||
| var _i2c = opts.i2c || PrimaryI2C; | |||
There was a problem hiding this comment.
в документации сказано, что объект opts ''должен'' содержать поля.
по факту он ''может'' содержать, но не обязан
modules/@amperka/meteo-sensor.js
Outdated
| }; | ||
|
|
||
| this.clockStretchingOn = function() { | ||
| _clockStretching = "ON" |
There was a problem hiding this comment.
если Iskra JS не умеет пользоваться clockStretching, то лучше не давать ручку к нему.
modules/@amperka/meteo-sensor.js
Outdated
| var data = _i2c.readFrom(_address, 6); | ||
| if (data[2] != _checkCRC8(data, 0, 2) || data[5] != _checkCRC8(data, 3, 5)) { | ||
| callback(new Error('checksum error'), { | ||
| tempC: -1, |
There was a problem hiding this comment.
не знаю как правильно, но я бы сделал undefined в случае ошибки. Так было бы проще отловить, что «что-то не то» в данных температуры. Иначе возникает вопрос «да почему минус один-то?», если человек не обрабатывает ошибки
|
Убрал выбор clockStretching, возвращаю undefined в случае ошибки, завернул все вызовы i2c в try...catch и возвращаю ошибку... |
igrztv
approved these changes
Aug 27, 2018
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://wiki.amperka.ru/js:meteo-sensor
@igrztv
@igor89
@acosinwork